ijuma commented on a change in pull request #11788:
URL: https://github.com/apache/kafka/pull/11788#discussion_r812220909
##########
File path: docs/upgrade.html
##########
@@ -24,7 +24,8 @@ <h5><a id="upgrade_320_notable"
href="#upgrade_320_notable">Notable changes in 3
<li>Idempotence for the producer is enabled by default. In 3.0.0 and
3.1.0, a bug prevented this default from being applied,
which meant that idempotence remained disabled unless the user had
explicitly set <code>enable.idempotence</code> to true
(See <a
href="https://issues.apache.org/jira/browse/KAFKA-13598";>KAFKA-13598</a>for
more details).
- This issue was fixed and the default is properly applied in 3.0.1,
3.1.1, and 3.2.0.</li>
+ This issue was fixed and the default is properly applied in 3.0.1,
3.1.1, and 3.2.0.
+ However, if <code>enable.idempotence</code> is unset and the other
configs conflicts with it, idempotence will be disabled to avoid breaking
existing producers.</li>
Review comment:
Maybe we can update the first sentence. "Idempotence for the producer is
enabled by default if no conflicting configurations are set explicitly." I
don't think we need the "However" part, we can include that detail in the KIP's
compatibility section instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
