mimaison commented on a change in pull request #10244:
URL: https://github.com/apache/kafka/pull/10244#discussion_r812791855
##########
File path:
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
##########
@@ -333,6 +333,7 @@ public void activateOptions() {
props.put(KEY_SERIALIZER_CLASS_CONFIG,
ByteArraySerializer.class.getName());
props.put(VALUE_SERIALIZER_CLASS_CONFIG,
ByteArraySerializer.class.getName());
this.producer = getKafkaProducer(props);
+ LogLog.warn("log4j-appender is deprecated and will be removed in a
future release. For migration, please refer to the latest documentation.");
Review comment:
Should we also annotate the class with `@Deprecated`?
##########
File path: bin/kafka-run-class.sh
##########
@@ -45,6 +45,45 @@ should_include_file() {
fi
}
+# As of present, the migration to log4j2 is not completed, so some modules are
using log4j 1.x, and
Review comment:
We don't have similar logic in `kafka-run-class.bat`, is this on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
