ableegoldman commented on pull request #11787: URL: https://github.com/apache/kafka/pull/11787#issuecomment-1050219306
Test failures are unrelated (filed https://issues.apache.org/jira/browse/KAFKA-13690) Merging to trunk, but will do an immediate followup PR to: 1. delete the new ErrorHandlingIntegrationTest file and see if I can consolidate the test in there with the existing tests in NamedTopologyIntegrationTest 2. see if I can also consolidate/cut down on some of the tests in NamedTopologyIntegrationTest (I believe there are some cases that can be compressed into a single test, saving the overhead of starting up the KafkaStreams app) 3. add unit tests 4. address nits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org