junrao commented on a change in pull request #10591: URL: https://github.com/apache/kafka/pull/10591#discussion_r815000220
########## File path: docs/ops.html ########## @@ -78,7 +78,7 @@ <h4 class="anchor-heading"><a id="basic_ops_leader_balancing" class="anchor-link <pre class="line-numbers"><code class="language-text"> auto.leader.rebalance.enable=true</code></pre> You can also set this to false, but you will then need to manually restore leadership to the restored replicas by running the command: - <pre class="line-numbers"><code class="language-bash"> > bin/kafka-preferred-replica-election.sh --bootstrap-server broker_host:port</code></pre> + <pre class="line-numbers"><code class="language-bash"> > bin/kafka-leader-election.sh --bootstrap-server broker_host:port</code></pre> Review comment: Yes, we did move to the kafka-leader-election tool. Could we add the complete command line to do preferred leader election? I think we need to add --election-type preferred. ########## File path: docs/security.html ########## @@ -2092,12 +2092,12 @@ <h4 class="anchor-heading"><a id="zk_authz_migration" class="anchor-link"></a><a <h4 class="anchor-heading"><a id="zk_authz_ensemble" class="anchor-link"></a><a href="#zk_authz_ensemble">7.6.3 Migrating the ZooKeeper ensemble</a></h4> It is also necessary to enable SASL and/or mTLS authentication on the ZooKeeper ensemble. To do it, we need to perform a rolling restart of the server and set a few properties. See above for mTLS information. Please refer to the ZooKeeper documentation for more detail: <ol> - <li><a href="https://zookeeper.apache.org/doc/r3.5.7/zookeeperProgrammers.html#sc_ZooKeeperAccessControl">Apache ZooKeeper documentation</a></li> + <li><a href="https://zookeeper.apache.org/doc/r3.5.9/zookeeperProgrammers.html#sc_ZooKeeperAccessControl">Apache ZooKeeper documentation</a></li> Review comment: The latest ZK version for Kafka is 3.6.3 now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org