ableegoldman commented on a change in pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#discussion_r816337445
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##########
@@ -230,53 +233,72 @@ public RemoveNamedTopologyResult
removeNamedTopology(final String topologyToRemo
topologyMetadata.unregisterTopology(removeTopologyFuture,
topologyToRemove);
- if (resetOffsets) {
+ if (!completedFutureForUnstartedApp(removeTopologyFuture, "removing
topology") && resetOffsets) {
Review comment:
We kind of assume that an application will not be doing heavy/frequent
#removeNamedTopology calls, if it turns out that users want to be able to add
and remove many topologies at a high rate then we can come back and try to
optimize this -- it just doesn't seem to make much sense for an application to
have such high turnover of topologies, this feature is generally speaking more
targeted at providing a relatively stable application the ability to update its
topology as needed, not for high volumes of transient topologies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
