cmccabe commented on a change in pull request #11809:
URL: https://github.com/apache/kafka/pull/11809#discussion_r818132811
##########
File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala
##########
@@ -176,4 +180,8 @@ object KafkaRaftServer {
(metaProperties, offlineDirs.toSeq)
}
+ val configSchema = new KafkaConfigSchema(Map(
+ ConfigResource.Type.BROKER -> KafkaConfig.configDef,
+ ConfigResource.Type.TOPIC -> LogConfig.configDefCopy,
Review comment:
In practice nobody mutates either of these. But you're right, it is
inconsistent. I will do a defensive copy on the KafkaConfig one.
In the future we should have a freeze method or something on the ConfigDef
to make these defensive copies unnecessary. But that's out of scope here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
