showuon commented on a change in pull request #11845: URL: https://github.com/apache/kafka/pull/11845#discussion_r819398657
########## File path: docs/ops.html ########## @@ -258,58 +258,51 @@ <h5 class="anchor-heading"><a id="basic_ops_automigrate" class="anchor-link"></a Current partition replica assignment {"version":1, - "partitions":[{"topic":"foo1","partition":2,"replicas":[1,2]}, - {"topic":"foo1","partition":0,"replicas":[3,4]}, - {"topic":"foo2","partition":2,"replicas":[1,2]}, - {"topic":"foo2","partition":0,"replicas":[3,4]}, - {"topic":"foo1","partition":1,"replicas":[2,3]}, - {"topic":"foo2","partition":1,"replicas":[2,3]}] + "partitions":[{"topic":"foo1","partition":0,"replicas":[2,1]}, + {"topic":"foo1","partition":1,"replicas":[1,3]}, + {"topic":"foo1","partition":2,"replicas":[3,4]}, + {"topic":"foo2","partition":0,"replicas":[4,2]}, + {"topic":"foo2","partition":1,"replicas":[2,1]}, + {"topic":"foo2","partition":2,"replicas":[1,3]}] } Proposed partition reassignment configuration {"version":1, - "partitions":[{"topic":"foo1","partition":2,"replicas":[5,6]}, - {"topic":"foo1","partition":0,"replicas":[5,6]}, - {"topic":"foo2","partition":2,"replicas":[5,6]}, - {"topic":"foo2","partition":0,"replicas":[5,6]}, + "partitions":[{"topic":"foo1","partition":0,"replicas":[6,5]}, {"topic":"foo1","partition":1,"replicas":[5,6]}, - {"topic":"foo2","partition":1,"replicas":[5,6]}] + {"topic":"foo1","partition":2,"replicas":[6,5]}, + {"topic":"foo2","partition":0,"replicas":[5,6]}, + {"topic":"foo2","partition":1,"replicas":[6,5]}, + {"topic":"foo2","partition":2,"replicas":[5,6]}] }</code></pre> <p> The tool generates a candidate assignment that will move all partitions from topics foo1,foo2 to brokers 5,6. Note, however, that at this point, the partition movement has not started, it merely tells you the current assignment and the proposed new assignment. The current assignment should be saved in case you want to rollback to it. The new assignment should be saved in a json file (e.g. expand-cluster-reassignment.json) to be input to the tool with the --execute option as follows: <pre class="line-numbers"><code class="language-bash"> > bin/kafka-reassign-partitions.sh --bootstrap-server localhost:9092 --reassignment-json-file expand-cluster-reassignment.json --execute Current partition replica assignment {"version":1, - "partitions":[{"topic":"foo1","partition":2,"replicas":[1,2]}, - {"topic":"foo1","partition":0,"replicas":[3,4]}, - {"topic":"foo2","partition":2,"replicas":[1,2]}, - {"topic":"foo2","partition":0,"replicas":[3,4]}, - {"topic":"foo1","partition":1,"replicas":[2,3]}, - {"topic":"foo2","partition":1,"replicas":[2,3]}] + "partitions":[{"topic":"foo1","partition":0,"replicas":[2,1]}, + {"topic":"foo1","partition":1,"replicas":[1,3]}, + {"topic":"foo1","partition":2,"replicas":[3,4]}, + {"topic":"foo2","partition":0,"replicas":[4,2]}, + {"topic":"foo2","partition":1,"replicas":[2,1]}, + {"topic":"foo2","partition":2,"replicas":[1,3]}] } Save this to use as the --reassignment-json-file option during rollback - Successfully started reassignment of partitions - {"version":1, - "partitions":[{"topic":"foo1","partition":2,"replicas":[5,6]}, - {"topic":"foo1","partition":0,"replicas":[5,6]}, - {"topic":"foo2","partition":2,"replicas":[5,6]}, - {"topic":"foo2","partition":0,"replicas":[5,6]}, - {"topic":"foo1","partition":1,"replicas":[5,6]}, - {"topic":"foo2","partition":1,"replicas":[5,6]}] - }</code></pre> + Successfully started partition reassignments for foo1-0,foo1-1,foo1-2,foo2-0,foo2-1,foo2-2 Review comment: We only show `Successfully started partition reassignments for...` in current script. Update it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org