guozhangwang commented on a change in pull request #11857:
URL: https://github.com/apache/kafka/pull/11857#discussion_r821006143



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##########
@@ -84,14 +84,14 @@
         public AtomicLong topologyVersion = new AtomicLong(0L); // the local 
topology version
         public ReentrantLock topologyLock = new ReentrantLock();
         public Condition topologyCV = topologyLock.newCondition();
-        public List<TopologyVersionWaiters> activeTopologyWaiters = new 
LinkedList<>();
+        public List<TopologyVersionListener> activeTopologyUpdateListeners = 
new LinkedList<>();

Review comment:
       Also another quick question regarding why we need to keep 
`topologyVersion` an atomic long? Seems besides the getters all of its updators 
are under the lock as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to