dengziming commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r821561398
##########
File path: config/kraft/server.properties
##########
@@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# This is required for combined role(i.e. process.roles=broker,controller)
node to set the listeners at least for controller
Review comment:
> must list the controller listener here at a minimum.
It seems that we can't only list controller listener here in combined mode
because `advertised.listeners` must be a subset of `listeners` and advertised
listener can not be empty. so we must always set both controller and broker
listeners here.
##########
File path: config/kraft/server.properties
##########
@@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093
############################# Socket Server Settings
#############################
-# The address the socket server listens on. It will get the value returned from
-# java.net.InetAddress.getCanonicalHostName() if not configured.
+# The address the socket server listens on.
+# This is required for combined role(i.e. process.roles=broker,controller)
node to set the listeners at least for controller
Review comment:
> must list the controller listener here at a minimum.
It seems that we can't only list controller listener here in combined mode
because `advertised.listeners` must be a subset of `listeners` and advertised
listener can not be empty. so we must always set both controller and broker
listeners here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
