vvcephei commented on pull request #11848: URL: https://github.com/apache/kafka/pull/11848#issuecomment-1062155813
Thanks for the review, @mjsax ! I like your suggestion about reordering that expression, but I think I'll go ahead and merge, rather than waiting for CIT again. The test failures were unrelated: ``` [Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_8_and_Scala_2_12___testSendWithInvalidCreateTime__/) [Build / JDK 8 and Scala 2.12 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_8_and_Scala_2_12___testSendWithInvalidCreateTime___2/) [Build / JDK 8 and Scala 2.12 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_8_and_Scala_2_12___testProduceWithInvalidTimestamp__/) [Build / JDK 8 and Scala 2.12 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_8_and_Scala_2_12___testProduceWithInvalidTimestamp___2/) Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPreferredReplicaElection, Security=PLAINTEXT [Build / JDK 17 and Scala 2.13 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_17_and_Scala_2_13___testSendWithInvalidCreateTime__/) [Build / JDK 17 and Scala 2.13 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_17_and_Scala_2_13___testSendWithInvalidCreateTime___2/) [Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_17_and_Scala_2_13___testThreadPoolResize__/) [Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_17_and_Scala_2_13___testThreadPoolResize___2/) [Build / JDK 17 and Scala 2.13 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_17_and_Scala_2_13___testProduceWithInvalidTimestamp__/) [Build / JDK 17 and Scala 2.13 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_17_and_Scala_2_13___testProduceWithInvalidTimestamp___2/) Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testDeleteConnector [Build / JDK 11 and Scala 2.13 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_11_and_Scala_2_13___testSendWithInvalidCreateTime__/) [Build / JDK 11 and Scala 2.13 / kafka.api.PlaintextProducerSendTest.testSendWithInvalidCreateTime()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.api/PlaintextProducerSendTest/Build___JDK_11_and_Scala_2_13___testSendWithInvalidCreateTime___2/) [Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_11_and_Scala_2_13___testThreadPoolResize__/) [Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_11_and_Scala_2_13___testThreadPoolResize___2/) [Build / JDK 11 and Scala 2.13 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_11_and_Scala_2_13___testProduceWithInvalidTimestamp__/) [Build / JDK 11 and Scala 2.13 / kafka.server.ProduceRequestTest.testProduceWithInvalidTimestamp()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11848/1/testReport/junit/kafka.server/ProduceRequestTest/Build___JDK_11_and_Scala_2_13___testProduceWithInvalidTimestamp___2/) Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.AdjustStreamThreadCountTest.shouldAddAndRemoveThreadsMultipleTimes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
