showuon commented on a change in pull request #11874: URL: https://github.com/apache/kafka/pull/11874#discussion_r823265635
########## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ########## @@ -404,8 +404,8 @@ "<code>org.apache.kafka.common.serialization.Serde</code> interface."; public static final String WINDOWED_INNER_CLASS_SERDE = "windowed.inner.class.serde"; - private static final String WINDOWED_INNER_CLASS_SERDE_DOC = " Default serializer / deserializer for the inner class of a windowed record. Must implement the \" +\n" + - " \"<code>org.apache.kafka.common.serialization.Serde</code> interface.. Note that setting this config in KafkaStreams application would result " + + private static final String WINDOWED_INNER_CLASS_SERDE_DOC = " Default serializer / deserializer for the inner class of a windowed record. Must implement the " + + "<code>org.apache.kafka.common.serialization.Serde</code> interface. Note that setting this config in KafkaStreams application would result " + Review comment: Nice catch! Note, current doc is like this: ![image](https://user-images.githubusercontent.com/43372967/157572498-c1200a0f-ac13-4f8d-b991-7d2f2e2e1d11.png) ########## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ########## @@ -216,8 +216,10 @@ private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC = "The maximum number of unacknowledged requests the client will send on a single connection before blocking." + " Note that if this config is set to be greater than 1 and <code>enable.idempotence</code> is set to false, there is a risk of" + " message re-ordering after a failed send due to retries (i.e., if retries are enabled)." - + " Additionally, enabling idempotence requires this config value to be less than or equal to " + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_FOR_IDEMPOTENCE + "." - + " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled."; + + " Additionally, enabling idempotence requires the value of this configuration to be less than or equal to " + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_FOR_IDEMPOTENCE + "." + + " If conflicting configurations are set and idempotence is not explicitly enabled, idempotence is disabled. " + + " Record ordering is preserved when <code>enable.idempotence</code> is set to true for idempotent " + + " producer (or transactional producer), even when max in-flight requests are greater than 1 (supported up to 5)."; Review comment: Actually, I think the original version is better. Could you revert this change, and only fix the typo in stream config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org