C0urante edited a comment on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745
Thanks for finding and fixing this @sunshujie1990! Changes like this one should usually come with a unit test to verify that the original bug exists, and that the proposed fix addresses it. I've drafted a small addition to an existing test case that should accomplish this in a personal fork that also includes your commit for this PR: https://github.com/C0urante/kafka/commit/ddd64ebc6400b9044a1358cf18c23d3d914d1f90 If that looks good to you, feel free to cherry-pick onto your branch and make any adjustments that you'd like. Given that the issue can be reproduced via unit test and that this fix does address it (by causing the test to pass), this LGTM once it has test coverage added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
