jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828546042
##########
File path: core/src/main/scala/kafka/server/ControllerServer.scala
##########
@@ -158,20 +158,30 @@ class ControllerServer(
alterConfigPolicy = Option(config.
getConfiguredInstance(AlterConfigPolicyClassNameProp,
classOf[AlterConfigPolicy]))
- val controllerBuilder = new QuorumController.Builder(config.nodeId,
metaProperties.clusterId).
- setTime(time).
- setThreadNamePrefix(threadNamePrefixAsString).
- setConfigSchema(configSchema).
- setRaftClient(raftManager.client).
- setDefaultReplicationFactor(config.defaultReplicationFactor.toShort).
- setDefaultNumPartitions(config.numPartitions.intValue()).
-
setSessionTimeoutNs(TimeUnit.NANOSECONDS.convert(config.brokerSessionTimeoutMs.longValue(),
- TimeUnit.MILLISECONDS)).
- setSnapshotMaxNewRecordBytes(config.metadataSnapshotMaxNewRecordBytes).
- setMetrics(new
QuorumControllerMetrics(KafkaYammerMetrics.defaultRegistry())).
- setCreateTopicPolicy(createTopicPolicy.asJava).
- setAlterConfigPolicy(alterConfigPolicy.asJava).
- setConfigurationValidator(new ControllerConfigurationValidator())
+ val controllerBuilder = {
+ val leaderImbalanceCheckIntervalNs = if
(config.autoLeaderRebalanceEnable) {
Review comment:
I added this check to `KafkaConfig`. :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
