dajac commented on a change in pull request #11900:
URL: https://github.com/apache/kafka/pull/11900#discussion_r830999098
##########
File path:
clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java
##########
@@ -71,7 +71,7 @@ public int hashCode() {
@Override
public boolean equals(Object o) {
- if (o == null || o.getClass() != o.getClass()) return false;
+ if ((o == null) || (!o.getClass().equals(getClass()))) return
false;
Review comment:
Oh.. I missed that. It thought it was only about using `equals`. Could
we keep using `!=` instead of `equals` though? It might be worth adding a small
unit test for this method, what do you think? That would avoid repeating such
mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
