rondagostino commented on pull request #11691:
URL: https://github.com/apache/kafka/pull/11691#issuecomment-1075280621


   Test passes with this change, but I don't understand why.
   `git diff 
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java`
   ```
   diff --git 
a/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
 
b/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
   index 23272a2cb5..edaf6589a7 100644
   --- 
a/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
   +++ 
b/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
   @@ -43,6 +43,7 @@ import static 
org.apache.kafka.clients.producer.ProducerConfig.LINGER_MS_CONFIG;
    import static 
org.apache.kafka.clients.producer.ProducerConfig.MAX_BLOCK_MS_CONFIG;
    import static 
org.apache.kafka.clients.producer.ProducerConfig.RETRIES_CONFIG;
    import static 
org.apache.kafka.clients.producer.ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG;
   +import static 
org.apache.kafka.clients.producer.ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG;
    import static org.apache.kafka.common.config.SaslConfigs.SASL_JAAS_CONFIG;
    import static 
org.apache.kafka.common.config.SaslConfigs.SASL_KERBEROS_SERVICE_NAME;
    import static org.apache.kafka.common.config.SaslConfigs.SASL_MECHANISM;
   @@ -332,6 +333,7 @@ public class KafkaLog4jAppender extends AppenderSkeleton 
{
   
            props.put(KEY_SERIALIZER_CLASS_CONFIG, 
ByteArraySerializer.class.getName());
            props.put(VALUE_SERIALIZER_CLASS_CONFIG, 
ByteArraySerializer.class.getName());
   +        props.put(ENABLE_IDEMPOTENCE_CONFIG, false);
            this.producer = getKafkaProducer(props);
            LogLog.debug("Kafka producer connected to " + brokerList);
            LogLog.debug("Logging for topic: " + topic);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to