kkonstantine commented on pull request #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1075479063
@showuon I noticed that you recently disable idempotency for the status backing store. Now that we remove `acks=all` should we add it there? Is this something we missed with the changes here? And taking an even closer look at the status backing store implementation, I see that retries are handled by that class. So we disable idempotence but are we sure `max.in.flight.requests.per.connection` is 1 there? Also, re: > @kkonstantine , thanks for the comment. I agree we add comments in the code to say the idempotent producer is enabled by default. my intention was actually to add a comment in the code to say what are the configs that we definitely require for the producers in Connect to work as intended. And these are `acks=all`, `max.in.flight.requests.per.connection=1` unless idempotency is enabled given that we have KAFKA-5494 and infinite retries. These requirements were reflected in actual code until this PR was merged. But now they are implied by the defaults of the idempotent producer and that's something I'd like to leave a trail of, so we know what works for Connect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
