showuon commented on a change in pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#discussion_r834904926
##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -70,7 +70,7 @@ object GetOffsetShell {
.withRequiredArg
.describedAs("partition ids")
.ofType(classOf[String])
- val timeOpt = parser.accepts("time", "timestamp of the offsets before
that. [Note: No offset is returned, if the timestamp greater than recently
committed record timestamp is given.]")
+ val timeOpt = parser.accepts("time", "timestamp of the offsets before
that. [Note: -1 indicates offset for the specified time is not found]")
Review comment:
I think the description is not clear. Basically, we defined `-1` means
`latest` in the `time` option. So, I think we should explicitly mention the
`returned offset`. ex:
[Note: The returned offset -1 indicates offset for the specified time is not
found]
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
