vvcephei commented on a change in pull request #11945: URL: https://github.com/apache/kafka/pull/11945#discussion_r834933864
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionResponseWrapperSerde.java ########## @@ -64,7 +64,7 @@ public void setIfUnset(final SerdeGetter getter) { @Override public byte[] serialize(final String topic, final SubscriptionResponseWrapper<V> data) { - //{1-bit-isHashNull}{7-bits-version}{Optional-16-byte-Hash}{n-bytes serialized data} + //{1-bit-isHashNull}{7-bits-version}{4-bytes-primaryPartition}{Optional-16-byte-Hash}{n-bytes serialized data} Review comment: Yeah, this is indeed a problem. It's the same issue I documented here: https://issues.apache.org/jira/browse/KAFKA-10336 I was also thinking that the rebalance metadata version could give us a mechanism to coordinate this kind of thing across a rolling bounce. I documented the approach in that ticket, but never got a chance to work on it. If we don't want to bite off a general solution to it, two rolling bounces might be the best compromise, as annoying as they are. Alternatively, since we actually do check the version and throw an exception if we encounter it, it is "safe" (in that there's no data corruption) to just go ahead and let the exceptions happen during a rolling bounce. Not the nicest thing to do, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org