showuon commented on a change in pull request #11796:
URL: https://github.com/apache/kafka/pull/11796#discussion_r837115301
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1038,14 +1041,15 @@ private static Metrics getMetrics(final StreamsConfig
config, final Time time, f
final StreamThread streamThread;
synchronized (changeThreadCount) {
final int threadIdx = getNextThreadIndex();
- final int numLiveThreads = getNumLiveStreamThreads();
- final long cacheSizePerThread =
getCacheSizePerThread(numLiveThreads + 1);
- log.info("Adding StreamThread-{}, there will now be {} live
threads and the new cache size per thread is {}",
- threadIdx, numLiveThreads + 1, cacheSizePerThread);
- resizeThreadCache(cacheSizePerThread);
// Creating thread should hold the lock in order to avoid
duplicate thread index.
// If the duplicate index happen, the metadata of thread may
be duplicate too.
- streamThread = createAndAddStreamThread(cacheSizePerThread,
threadIdx);
+ // Also, we create the new thread with initial values of cache
size and max buffer size as 0
+ // and then resize them later
+ streamThread = createAndAddStreamThread(0L, 0L, threadIdx);
+ final int numLiveThreads = getNumLiveStreamThreads();
+ resizeThreadCacheAndBufferMemory(numLiveThreads + 1);
Review comment:
I read the code change, and I agree with you. We don't need `+1`
anymore. Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
