rhauch commented on a change in pull request #11908:
URL: https://github.com/apache/kafka/pull/11908#discussion_r837938762
##########
File path: docs/quickstart.html
##########
@@ -173,9 +173,14 @@ <h4 class="anchor-heading">
</p>
<p>
- First, make sure to add <code
class="language-bash">connect-file-{{fullDotVersion}}.jar</code> to the
<code>plugin.path</code> property in the Connect worker's configuration (see <a
href="#connectconfigs_plugin.path">plugin.path</a> for examples).
+ First, make sure to add <code
class="language-bash">connect-file-{{fullDotVersion}}.jar</code> to the
<code>plugin.path</code> property in the Connect worker's configuration.
+ For the purpose of this quickstart we'll use a relative path and
consider the connectors' package as an uber jar.
+ However, it's worth noting that for production deployments using
absolute paths is always preferable. See <a
href="#connectconfigs_plugin.path">plugin.path</a> for a detailed description
of how to set this config.
Review comment:
Minor suggestion to be even more concrete and to avoid sending the
reader to a different location in the docs:
```suggestion
For the purpose of this quickstart we'll use a relative path and
consider the connectors' package as an uber jar,
which works when the quickstart commands are run from the
installation directory.
However, it's worth noting that for production deployments using
absolute paths is always preferable. See <a
href="#connectconfigs_plugin.path">plugin.path</a> for a detailed description
of how to set this config.
</p>
<p>
Edit the <code
class="language-bash">config/connect-standalone.properties</code> file, add or
change the <code>plugin.path</code> configuration property match the following,
and save the file:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
