dajac opened a new pull request #11971:
URL: https://github.com/apache/kafka/pull/11971


   KIP-800 introduced a mechanism to pass a reason in the join group request 
and in the leaver group request. A default reason is used unless one is 
provided by the user. In this case, the custom reason is prefixed by the 
default one.
   
   When we tried to used this in Kafka Streams, we noted a significant 
degradation of the performances, see 
https://github.com/apache/kafka/pull/11873. It is not clear wether the 
prefixing is the root cause of the issue or not. To be on the safe side, I 
think that we should remove the prefixing. It does not bring much anyway as we 
are still able to distinguish a custom reason from the default one on the 
broker side.
   
   This patch removes prefixing the user provided reasons. So if a the user 
provides a reason, the reason is used directly. If the reason is empty or null, 
the default reason is used.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to