showuon commented on a change in pull request #11978:
URL: https://github.com/apache/kafka/pull/11978#discussion_r840165481
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -766,7 +766,9 @@ object KafkaConfig {
"listener.security.protocol.map = INTERNAL:PLAINTEXT, EXTERNAL:SSL,
CONTROLLER:SSL\n" +
"control.plane.listener.name = CONTROLLER\n" +
"then controller will use \"broker1.example.com:9094\" with security
protocol \"SSL\" to connect to the broker.\n" +
- "If not explicitly configured, the default value will be null and there
will be no dedicated endpoints for controller connections."
+ "If not explicitly configured, the default value will be null and there
will be no dedicated endpoints for controller connections." +
+ s" And the value of <code>$InterBrokerListenerNameProp</code> will be used
for controller connections.\n" +
Review comment:
After checking the code and docs, I found the line to get
`interBrokerListenerName`, is actually trying to get inter broker listener
name, OR `security.inter.broker.protocol`:
```
val controllerToBrokerListenerName =
config.controlPlaneListenerName.getOrElse(config.interBrokerListenerName)
```
I'm still thinking the explanation is complicated and redundant. Could we
just add the last line only. That is:
```
"If not explicitly configured, the default value will be null and there will
be no dedicated endpoints for controller connections." +
s"If explicitly configured, the value cannot be the same as the value of
<code>$InterBrokerListenerNameProp</code>."
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
