[ 
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517159#comment-17517159
 ] 

Chris Egerton commented on KAFKA-7509:
--------------------------------------

Hmm... I'm not able to reproduce this easily with Kafka Streams. It looks like 
care is already taken to filter out most irrelevant client properties with 
logic like 
[this|https://github.com/apache/kafka/blob/74909e000aaab1f0300ae2e918a6fa361e38078e/streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java#L1580-L1598].
 I think it might still be possible to trigger the unrecognized config warning 
by passing in interceptor properties in the top level streams config, but since 
you can already isolate client properties with separate {{{}producer.{}}}, 
{{{}consumer.{}}}, and {{admin.}} namespaces, there doesn't seem to be any need 
to make code changes to address that case.

[~mjsax] [~vvcephei] do either of you know if KAFKA-6793 is still an issue? And 
if so, do you know off the top of your head how to go about reproducing these 
warning messages with Kafka Streams?

If Kafka Streams has already taken care of everything then that should simplify 
the review process for [https://github.com/apache/kafka/pull/11986].

> Kafka Connect logs unnecessary warnings about unused configurations
> -------------------------------------------------------------------
>
>                 Key: KAFKA-7509
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7509
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, KafkaConnect
>    Affects Versions: 0.10.2.0
>            Reporter: Randall Hauch
>            Assignee: Chris Egerton
>            Priority: Major
>
> When running Connect, the logs contain quite a few warnings about "The 
> configuration '{}' was supplied but isn't a known config." This occurs when 
> Connect creates producers, consumers, and admin clients, because the 
> AbstractConfig is logging unused configuration properties upon construction. 
> It's complicated by the fact that the Producer, Consumer, and AdminClient all 
> create their own AbstractConfig instances within the constructor, so we can't 
> even call its {{ignore(String key)}} method.
> See also KAFKA-6793 for a similar issue with Streams.
> There are no arguments in the Producer, Consumer, or AdminClient constructors 
> to control  whether the configs log these warnings, so a simpler workaround 
> is to only pass those configuration properties to the Producer, Consumer, and 
> AdminClient that the ProducerConfig, ConsumerConfig, and AdminClientConfig 
> configdefs know about.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to