[GitHub] [kafka] mimaison commented on a diff in pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

Tue, 05 Apr 2022 03:01:33 -0700 


mimaison commented on code in PR #11974:
URL: https://github.com/apache/kafka/pull/11974#discussion_r842589656


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##########
@@ -76,23 +83,21 @@
 
     @Parameters
     public static Iterable<?> mode() {
-        return Arrays.asList(new Object[][] {{CONNECT_PROTOCOL_V1, 
CONNECT_PROTOCOL_V2}});
+        return Arrays.asList(new Object[][] {{CONNECT_PROTOCOL_V1}, 
{CONNECT_PROTOCOL_V2}});

Review Comment:
   This can be simplified into `return Arrays.asList(CONNECT_PROTOCOL_V1, 
CONNECT_PROTOCOL_V2);` but since you're removing it in 
https://github.com/apache/kafka/pull/11983, we can ignore it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to