showuon commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r845685014
##########
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##########
@@ -1083,6 +1083,26 @@ public String toString() {
}
}
+ public static class NonNullAndEmptyString implements Validator {
Review Comment:
Sorry, `ConfigDef` is public API, needs KIP.
##########
clients/src/main/java/org/apache/kafka/common/config/SslClientAuth.java:
##########
@@ -45,4 +56,8 @@ public static SslClientAuth forConfig(String key) {
}
return null;
}
+
+ public static List<String> names() {
Review Comment:
Sorry, `SslClientAuth` is public API.
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java:
##########
@@ -49,15 +53,15 @@ public void testClusterConfigProperties() {
"clusters", "a, b",
"a.bootstrap.servers", "servers-one",
"b.bootstrap.servers", "servers-two",
- "security.protocol", "SASL",
+ "security.protocol", "SSL",
Review Comment:
Why do we need this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
