junrao commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r850679270
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -2615,7 +2615,10 @@ class ReplicaManagerTest {
@Test
def
testStopReplicaWithDeletePartitionAndExistingPartitionAndNewerLeaderEpochAndIOException():
Unit = {
Review Comment:
@gitlw : With your change, it's true there is no IOException in the
synchronous call to stopReplicas(). However, the async delete part will
eventually hit an IOException and convert that to a KafkaStorageException.
Perhaps we could have a mock LogDirFailureChannel to verify that a
KafkaStorageException is eventually propagated there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
