[GitHub] [kafka] C0urante commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

[GitBox]

C0urante commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r853568629


##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {
                                         
MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION_DOC)
                                 .define(KEY_SERIALIZER_CLASS_CONFIG,
                                         Type.CLASS,
+                                        ConfigDef.NO_DEFAULT_VALUE,
+                                        new ConfigDef.NonNullValidator(),

Review Comment:
   This is a fair point... people may be using 
`ProducerConfig`/`ConsumerConfig` instances on their own without using a 
`KafkaProducer`/`KafkaConsumer` to construct them. In that case, if they 
haven't specified a value (or have explicitly specified `null`) for the 
key/value serializer/deserializer class, then upgrading to a version of Kafka 
that contains this change will cause things to break.
   
   I'm unclear on how/why we'd want to change `appendSerializerToConfig`, 
though?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org