vamossagar12 commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r854022038
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBWindowStoreTest.java:
##########
@@ -181,15 +189,16 @@ public void testRolling() {
),
segmentDirs(baseDir)
);
-
+ // expired record
assertEquals(
- new HashSet<>(Collections.singletonList("zero")),
+ new HashSet<>(Collections.emptyList()),
Review Comment:
@showuon , can you plz give an example of `I'm afraid this change will not
catch the expected error when code changes unexpectedly` ? The reason I ask is,
because the underlying fetch logic has changed, it's slightly difficult to find
one generic high retention period to make all test cases work as is. I tried by
setting a range of values upto 10 * 60k, but still there are test failures.
Also, the reason I changed the test cases is that, the test cases should
also reflect the expired records. I agree that ideally we should have been
creating 2 separate test cases, but with the changes made, the values that get
returned depend upon what has been stored so far which entails test cases
change anyways.
Let me know if you agree to this..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
