jsancio commented on code in PR #11732:
URL: https://github.com/apache/kafka/pull/11732#discussion_r856668003
##########
core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala:
##########
@@ -43,8 +45,9 @@ class ConfigCommandIntegrationTest extends QuorumTestHarness
with Logging {
"--add-config", "security.inter.broker.protocol=PLAINTEXT"))
}
- @Test
- def shouldExitWithNonZeroStatusOnZkCommandAlterUserQuota(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk"))
+ def shouldExitWithNonZeroStatusOnZkCommandAlterUserQuota(quorum: String):
Unit = {
Review Comment:
Can you confirm that you need a ZK cluster to perform this test? If not can
we move it to the suite that doesn't inherent from `QuorumTestHarness`?
##########
core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala:
##########
@@ -26,15 +26,17 @@ import org.apache.kafka.common.config.ConfigException
import org.apache.kafka.common.network.ListenerName
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.jupiter.api.Assertions._
-import org.junit.jupiter.api.Test
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
import scala.collection.Seq
import scala.jdk.CollectionConverters._
class ConfigCommandIntegrationTest extends QuorumTestHarness with Logging {
- @Test
- def shouldExitWithNonZeroStatusOnUpdatingUnallowedConfigViaZk(): Unit = {
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk"))
+ def shouldExitWithNonZeroStatusOnUpdatingUnallowedConfigViaZk(quorum:
String): Unit = {
Review Comment:
Can you confirm that you need a ZK cluster to perform this test? If not can
we move it to the suite that doesn't inherent from `QuorumTestHarness`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
