dengziming commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r857081631
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.Arrays; +import java.util.stream.Collectors; +import org.apache.kafka.common.config.ConfigDef.Validator; +import org.apache.kafka.common.config.ConfigException; + +public class MetadataVersionValidator implements Validator { + + @Override + public void ensureValid(String name, Object value) { + try { + MetadataVersion.fromVersionString(value.toString()); + } catch (IllegalArgumentException e) { + throw new ConfigException(name, value.toString(), e.getMessage()); + } + } + + @Override + public String toString() { Review Comment: Should we put this method in MetadataVersion? similar to what we do in `ApiKeys`. ########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.common; + +import java.util.Arrays; +import java.util.HashMap; +import java.util.Map; +import java.util.Optional; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.kafka.common.record.RecordVersion; + +public enum MetadataVersion { + IBP_0_8_0(-1), Review Comment: Should we move all comments to here? for example, Introduced AlterPartition (KIP-497) for IBP_2_7_IV2 ########## core/src/test/scala/unit/kafka/api/ApiVersionTest.scala: ########## @@ -184,6 +184,38 @@ class ApiVersionTest { assertEquals("3.2", KAFKA_3_2_IV0.shortVersion) } + @Test Review Comment: How about directly removing ApiVersion and ApiVersionTest? they are not used any longer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
