[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #10738: KAFKA-6945: KIP-373, allow users to create delegation token for others

Mon, 25 Apr 2022 05:29:01 -0700 


viktorsomogyi commented on code in PR #10738:
URL: https://github.com/apache/kafka/pull/10738#discussion_r857571909


##########
core/src/main/scala/kafka/security/authorizer/AclEntry.scala:
##########
@@ -100,9 +100,10 @@ object AclEntry {
     resourceType match {
       case ResourceType.TOPIC => Set(READ, WRITE, CREATE, DESCRIBE, DELETE, 
ALTER, DESCRIBE_CONFIGS, ALTER_CONFIGS)
       case ResourceType.GROUP => Set(READ, DESCRIBE, DELETE)
-      case ResourceType.CLUSTER => Set(CREATE, CLUSTER_ACTION, 
DESCRIBE_CONFIGS, ALTER_CONFIGS, IDEMPOTENT_WRITE, ALTER, DESCRIBE)
+      case ResourceType.CLUSTER => Set(CREATE, CLUSTER_ACTION, 
DESCRIBE_CONFIGS, ALTER_CONFIGS, IDEMPOTENT_WRITE, ALTER, DESCRIBE, 
CREATE_TOKENS, DESCRIBE_TOKENS)

Review Comment:
   Oh, thanks for pointing it out, I think it wasn't intentional. Will remove 
it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to