junrao commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r857864434
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -3325,6 +3325,32 @@ class UnifiedLogTest {
assertEquals(1, log.numberOfSegments)
}
+ /**
+ * test renaming a log's dir without reinitialization, which is the case
during topic deletion
+ */
+ @Test
+ def testRenamingDirWithoutReinitialization(): Unit = {
+ val logConfig = LogTestUtils.createLogConfig(segmentBytes = 1024 * 1024)
+ val log = createLog(logDir, logConfig)
+ assertEquals(1, log.numberOfSegments, "The number of segments should be 1")
+
+ val newDir = TestUtils.randomPartitionLogDir(tmpDir)
+ assertTrue(newDir.exists())
+
+ log.renameDir(newDir.getName, false)
+ assertEquals(0, log.logEndOffset)
+ // verify that records appending can still succeed
+ // even with the uninitialized leaderEpochCache and partitionMetadataFile
+ val records = TestUtils.records(List(new
SimpleRecord(mockTime.milliseconds, "key".getBytes, "value".getBytes)))
+ log.appendAsLeader(records, leaderEpoch = 0)
+ assertEquals(1, log.logEndOffset)
+
+ // verify that the background deletion can succeed
+ log.delete()
Review Comment:
Could we add the test that if log.delete() hits an IOException, it's
propagated to logDirFailureChannel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
