ijuma commented on code in PR #12052:
URL: https://github.com/apache/kafka/pull/12052#discussion_r858994743
##########
docs/design.html:
##########
@@ -125,6 +125,9 @@ <h3 class="anchor-heading"><a id="maximizingefficiency"
class="anchor-link"></a>
<p>
This combination of pagecache and sendfile means that on a Kafka cluster
where the consumers are mostly caught up you will see no read activity on the
disks whatsoever as they will be serving data entirely from cache.
<p>
+ TLS/SSL libraries operate at the user space (in-kernel
<code>SSL_sendfile</code> is currently not supported by Kafka). Due to this
restriction, <code>sendfile</code> could not be used when transport layer
enables SSL protocol. For enabling
Review Comment:
Nit: "could not be used when transport layer enables SSL protocol" -> "is
not be used when SSL is enabledl"
##########
docs/design.html:
##########
@@ -125,6 +125,9 @@ <h3 class="anchor-heading"><a id="maximizingefficiency"
class="anchor-link"></a>
<p>
This combination of pagecache and sendfile means that on a Kafka cluster
where the consumers are mostly caught up you will see no read activity on the
disks whatsoever as they will be serving data entirely from cache.
<p>
+ TLS/SSL libraries operate at the user space (in-kernel
<code>SSL_sendfile</code> is currently not supported by Kafka). Due to this
restriction, <code>sendfile</code> could not be used when transport layer
enables SSL protocol. For enabling
Review Comment:
Nit: "could not be used when transport layer enables SSL protocol" -> "is
not be used when SSL is enabled"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
