dengziming commented on code in PR #12104:
URL: https://github.com/apache/kafka/pull/12104#discussion_r861428332
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
killBroker(0)
val aliveServers = brokers.filterNot(_.config.brokerId == 0)
TestUtils.waitForPartitionMetadata(aliveServers, underMinIsrTopic, 0)
- val output = TestUtils.grabConsoleOutput(
- topicService.describeTopic(new
TopicCommandOptions(Array("--under-min-isr-partitions"))))
+ var output = ""
+ TestUtils.waitUntilTrue(
+ () => {
+ output = TestUtils.grabConsoleOutput(
+ topicService.describeTopic(new
TopicCommandOptions(Array("--under-min-isr-partitions"))))
Review Comment:
Your approach is viable, however, we can avoid sending extra RPCs if we can
directly refer to BrokerServer like this:
`TestUtils.waitUntilTrue(brokers.forall(broker =>
broker.metadataCache.offlineTopic.length == 2))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
