artemlivshits commented on code in PR #12049: URL: https://github.com/apache/kafka/pull/12049#discussion_r861378007
########## clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java: ########## @@ -117,10 +116,24 @@ public MockProducer(final Cluster cluster, * * Equivalent to {@link #MockProducer(Cluster, boolean, Partitioner, Serializer, Serializer)} new MockProducer(Cluster.empty(), autoComplete, new DefaultPartitioner(), keySerializer, valueSerializer)} */ + @SuppressWarnings("deprecation") public MockProducer(final boolean autoComplete, final Serializer<K> keySerializer, final Serializer<V> valueSerializer) { - this(Cluster.empty(), autoComplete, new DefaultPartitioner(), keySerializer, valueSerializer); + this(Cluster.empty(), autoComplete, new org.apache.kafka.clients.producer.internals.DefaultPartitioner(), keySerializer, valueSerializer); Review Comment: Yeah, that's a good question. The MockProducer doesn't have RecordAccumulator, so I just left the code as it was. Interestingly, this code never calls "onNewBatch", so the default partitioner never switches partition. But I think we should fix it as a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org