divijvaidya commented on PR #12106: URL: https://github.com/apache/kafka/pull/12106#issuecomment-1116036542
The code looks good but as I said earlier, we are missing tests that assert that `validateOnly` flag is working as expected. The tests added in this PR are simply validating whether the flag was passed or not. Instead, we want to validate that when the flag is set to `false` no change takes place. But I think adding that test is out of scope for this PR since it may require refactoring and having a consistent boundary for termination of `validateOnly` flag for various APIs. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
