dengziming commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r865581359
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -215,13 +215,17 @@ private void
incrementalAlterConfigResource(ConfigResource configResource,
}
List<String> newValueParts = getParts(newValue, key,
configResource);
if (opType == APPEND) {
- if (!newValueParts.contains(opValue)) {
- newValueParts.add(opValue);
+ for (String value: opValue.split(",")) {
+ if (!newValueParts.contains(value)) {
Review Comment:
Nice catch, found a small bug of `ConfigAdminManager` when working on this
integration test.
for the variable naming, I think both are OK here, I used `oldValueList` to
be a better one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
