konL opened a new pull request, #12124:
URL: https://github.com/apache/kafka/pull/12124
I used deep learning to discover that the method 'isDone' changed in
4af50bb8600c37ee2e3597fba9a54a29cef94afa.
The code snippet before and after the change is as follows.
```
public boolean isDone() {
return isDone;
}
```
```
public boolean isDone() {
return result.get() != INCOMPLETE_SENTINEL;
}
```
We thought we could rename `isDone` to `hasComplete` with a more specific
meaning.
We are actually looking at analysing the reasons for renaming identifiers
and we would like to get advice from more experienced people, so would
appreciate your feedback from one of the following perspectives.
1. `(merge)`you accept this renaming opportunity and agree with the
recommended name
2. `(agree and not recommend)`you accept the renaming but disagree with the
recommended name, do you think the recommended name means the same thing or is
the recommended name simply not suitable?
3. `(not agree and useful)`Would our suggested renaming opportunity be
useful for your other refactoring activities?
4. `(not agree and not fix) `You do not think our suggested renaming
opportunity is appropriate. Is this because you think the identifier meaning
does not need to be renamed or is it some other issue?
We look forward to your feedback!
Thank you!
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
