[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532518#comment-17532518 ]
François Rosière edited comment on KAFKA-13864 at 5/6/22 7:01 PM: ------------------------------------------------------------------ [~Jack-Lee] , the PR has been commented based on the last updates made on the KIP. More details can be found in the discussion thread. Thanks. was (Author: JIRAUSER288866): Thanks for the PR. I added some comments. To progress on this issue, we still miss a vote or an approval to be able to merge the issue once it will have been fully reviewed... > Change the visibility of a KafkaProducer and KafkaConsumer constructor > ---------------------------------------------------------------------- > > Key: KAFKA-13864 > URL: https://issues.apache.org/jira/browse/KAFKA-13864 > Project: Kafka > Issue Type: Improvement > Components: clients > Affects Versions: 3.1.0 > Reporter: François Rosière > Assignee: lqjacklee > Priority: Major > Labels: needs-kip > > To allow implementing Spring managed interceptors for producers and consumers, > [https://github.com/spring-projects/spring-kafka/issues/2244] > The following changes should be applied in Kafka > 1. Create 2 new constructors in _KafkaProducer_ > {code:java} > public KafkaProducer(ProducerConfig config) > public KafkaProducer(ProducerConfig config, Serializer<K> keySerializer, > Serializer<V> valueSerializer) {code} > 2. Create a new constructor + increase the visibility of an existing > constructor in _KafkaConsumer_ > {code:java} > public KafkaConsumer(ConsumerConfig config) > public KafkaConsumer(ConsumerConfig config, Deserializer<K> keyDeserializer, > Deserializer<V> valueDeserializer){code} > 3. Create 2 new constructors in _TopologyTestDriver_ > {code:java} > public TopologyTestDriver(Topology topology, StreamsConfig config) > public TopologyTestDriver(Topology topology, StreamsConfig config, Instant > initialWallClockTime) {code} > More details can be found in the related KIP > [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578] > -- This message was sent by Atlassian Jira (v8.20.7#820007)