mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r867531749


##########
clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java:
##########
@@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {
         assertEquals(Long.valueOf(123L),
                 
reconnectBackoffSetConf.getLong(CommonClientConfigs.RECONNECT_BACKOFF_MAX_MS_CONFIG));
     }
+
+    @Test
+    public void testInvalidSaslMechanism() {

Review Comment:
   Actually since this is testing logic that is in `CommonClientConfigs`, maybe 
it's better to keep this here. Otherwise we'd move 
`postValidateSaslMechanismConfig()` in `SaslConfigs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to