mjsax commented on code in PR #12122:
URL: https://github.com/apache/kafka/pull/12122#discussion_r869751965
##########
streams/upgrade-system-tests-31/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java:
##########
@@ -63,21 +80,30 @@ public static void main(final String[] args) throws
Exception {
}));
}
- private static <KIn, VIn, KOut, VOut> ProcessorSupplier<KIn, VIn, KOut,
VOut> printProcessorSupplier() {
+ private static void buildFKTable(final KStream<String, Integer>
primaryTable,
+ final KTable<Integer, String> otherTable) {
Review Comment:
nit: indention
##########
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##########
@@ -37,6 +37,7 @@
metadata_1_versions = [str(LATEST_0_10_0)]
metadata_2_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2),
str(LATEST_0_11_0), str(LATEST_1_0), str(LATEST_1_1)]
+fk_join_versions = [str(V_2_4_0)]
Review Comment:
We only test with latest bug-fix releases, so we can use `LATEST_2_4` here.
##########
tests/kafkatest/tests/streams/streams_upgrade_test.py:
##########
@@ -37,6 +37,7 @@
metadata_1_versions = [str(LATEST_0_10_0)]
metadata_2_versions = [str(LATEST_0_10_1), str(LATEST_0_10_2),
str(LATEST_0_11_0), str(LATEST_1_0), str(LATEST_1_1)]
+fk_join_versions = [str(V_2_4_0)]
Review Comment:
Should we test all versions 2.4 - 3.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
