cmccabe commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r871851698
##########
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##########
@@ -72,6 +73,12 @@ class BrokerFeatures private (@volatile var
supportedFeatures: Features[Supporte
object BrokerFeatures extends Logging {
def createDefault(): BrokerFeatures = {
+ new BrokerFeatures(Features.supportedFeatures(
+ java.util.Collections.singletonMap(MetadataVersion.FEATURE_NAME,
Review Comment:
Maybe this is out of scope for this PR, but it seems like the
`BrokerFeatures` class just duplicates `FinalizedControllerFeatures`. Why not
just use `FinalizedControllerFeatures` instead in the old controller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
