ijuma commented on code in PR #12163: URL: https://github.com/apache/kafka/pull/12163#discussion_r872799071
########## clients/src/main/java/org/apache/kafka/common/utils/Checksums.java: ########## @@ -40,10 +55,32 @@ public static void update(Checksum checksum, ByteBuffer buffer, int length) { public static void update(Checksum checksum, ByteBuffer buffer, int offset, int length) { if (buffer.hasArray()) { checksum.update(buffer.array(), buffer.position() + buffer.arrayOffset() + offset, length); - } else { - int start = buffer.position() + offset; - for (int i = start; i < start + length; i++) - checksum.update(buffer.get(i)); + return; + } + if (BYTE_BUFFER_UPDATE != null) { + final int oldPosition = buffer.position(); + final int oldLimit = buffer.limit(); + try { + // save a slice to be used to save an allocation in the hot-path + final int start = buffer.position() + offset; + buffer.position(0); + buffer.limit(start + length); + buffer.position(start); + BYTE_BUFFER_UPDATE.invokeExact(checksum, buffer); + return; + } catch (Throwable t) { + // fallback Review Comment: Shouldn't we propagate the exception instead of falling back? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org