fvaleri commented on code in PR #12159:
URL: https://github.com/apache/kafka/pull/12159#discussion_r874001986
##########
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##########
@@ -449,9 +450,9 @@ public void close() {
@Test
public void testCloseOldestConnection() throws Exception {
String id = "0";
- blockingConnect(id);
-
- time.sleep(6000); // The max idle time is 5000ms
+ selector.connect(id, new InetSocketAddress("localhost", server.port),
BUFFER_SIZE, BUFFER_SIZE);
+ selector.poll(0);
Review Comment:
Hi @divijvaidya, thanks for looking at this. I need to fix this and
`testCloseOldestConnectionWithMultiplePendingReceives`.
##########
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##########
@@ -449,9 +450,9 @@ public void close() {
@Test
public void testCloseOldestConnection() throws Exception {
String id = "0";
- blockingConnect(id);
-
- time.sleep(6000); // The max idle time is 5000ms
+ selector.connect(id, new InetSocketAddress("localhost", server.port),
BUFFER_SIZE, BUFFER_SIZE);
+ selector.poll(0);
Review Comment:
Hi @divijvaidya, thanks for looking at this.
I need to fix this and
`testCloseOldestConnectionWithMultiplePendingReceives`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
