vamossagar12 commented on PR #11211: URL: https://github.com/apache/kafka/pull/11211#issuecomment-1129126264
@guozhangwang / @lihaosky , with all the changes happening around https://issues.apache.org/jira/browse/KAFKA-13785, there's an interesting side effect on this PR. Problem is happening around this integration test: https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/integration/TimeWindowedKStreamIntegrationTest.java and specifically for cases when ON_WINDOW_CLOSE strategy is used. In this PR, to filter expired records, I use a formula => `actualFrom = observedStreamTime - retention + 1` which is the standard way. Now, for all the test cases, the `to` value is less than `actualFrom` and for windowed schema types, I have added a check like this =>[https://github.com/apache/kafka/blob/033aeacb6a713d7a3b10bd6b30e9d1bb2cf72afd/stre[…]te/internals/AbstractRocksDBTimeOrderedSegmentedBytesStore.java] (https://github.com/apache/kafka/blob/033aeacb6a713d7a3b10bd6b30e9d1bb2cf72afd/streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBTimeOrderedSegmentedBytesStore.java#L147-L149) as when to < from for windowed, i get an illegalargument exception. Now my problem is, with all these changes in this PR, for every test in the in integration test, for WINDOW_CLOSE I don't get any records returned. Anything specific that I am missing here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
