hachikuji commented on code in PR #12110:
URL: https://github.com/apache/kafka/pull/12110#discussion_r875178010
##########
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##########
@@ -505,7 +505,7 @@ object ConfigAdminManager {
}
case OpType.SUBTRACT => {
if (!listType(alterConfigOp.configEntry.name, configKeys))
- throw new InvalidRequestException(s"Config value subtract is not
allowed for config key: ${alterConfigOp.configEntry.name}")
+ throw new InvalidConfigurationException(s"Config value subtract is
not allowed for config key: ${alterConfigOp.configEntry.name}")
Review Comment:
I think the change makes sense. Do we have any tests which cover these case?
##########
core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala:
##########
@@ -141,12 +141,13 @@ class AdminClientWithPoliciesIntegrationTest extends
KafkaServerTestHarness with
topicResource3 -> new Config(topicConfigEntries3),
brokerResource -> new Config(brokerConfigEntries)
).asJava)
+ ensureConsistentKRaftMetadata()
Review Comment:
nit: this one doesn't seem necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
