andymg3 commented on code in PR #12160: URL: https://github.com/apache/kafka/pull/12160#discussion_r876396975
########## metadata/src/test/java/org/apache/kafka/image/AclsDeltaTest.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.image; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.metadata.AccessControlEntryRecord; +import org.apache.kafka.common.metadata.RemoveAccessControlEntryRecord; +import org.apache.kafka.metadata.authorizer.StandardAcl; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.Timeout; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Optional; + +@Timeout(40) +public class AclsDeltaTest { + + private Uuid aclId = Uuid.fromString("iOZpss6VQUmD6blnqzl50g"); + + @Test + public void testRemovesDeleteIfNotInImage() { + AclsImage image = new AclsImage(Collections.emptyMap()); + AclsDelta delta = new AclsDelta(image); + AccessControlEntryRecord inputAclRecord = testAccessControlEntryRecord(); + + assertEquals(0, delta.changes().size()); + + delta.replay(inputAclRecord); + assertTrue(delta.changes().containsKey(aclId)); + assertTrue(delta.changes().get(aclId).isPresent()); Review Comment: Good point. I think I can get rid of those two above assertions now. I just tested this with an invalid input to the Map and saw: ``` AclsDeltaTest > testRemovesDeleteIfNotInImage() FAILED org.opentest4j.AssertionFailedError: expected: <Optional[StandardAcl(resourceType=ANY, resourceName=foo, patternType=ANY, principal=User:user, host=host, operation=ANY, permissionType=ANY)]> but was: <null> ``` So we should be safe from seeing a NPE. Will update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
