hachikuji commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r876448765
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2143,11 +2144,17 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
}
// Verify that createTopics and alterConfigs fail with null values
- @Test
- def testNullConfigs(): Unit = {
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testNullConfigs(quorum: String): Unit = {
def validateLogConfig(compressionType: String): Unit = {
- val logConfig = zkClient.getLogConfigs(Set(topic),
Collections.emptyMap[String, AnyRef])._1(topic)
+ val logConfig = if (isKRaftTest()) {
Review Comment:
Since we are consulting the metadata cache here, maybe it makes sense to
call `ensureConsistentKRaftMetadata()` here. Then we can get rid of the call
below.
While we're at it, perhaps we can replace a few explicit calls to
`TestUtils.ensureConsistentKRaftMetadata`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
