rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r877577941
##########
core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala:
##########
@@ -40,9 +42,15 @@ import scala.collection.Map
* setOffsetsForNextResponse
*/
class ReplicaFetcherMockBlockingSend(offsets: java.util.Map[TopicPartition,
EpochEndOffset],
- sourceBroker: BrokerEndPoint,
+ override private[server] val
sourceBroker: BrokerEndPoint,
time: Time)
- extends BlockingSend {
+ extends BrokerBlockingSender(sourceBroker = sourceBroker,
Review Comment:
Would there ever be a scenario in which we wouldn't want `brokerEndPoint` to
be a part of the `BlockingSend` trait? I.e., is there ever an implementation of
`BlockingSend` in which a `brokerEndPoint` would be extraneous?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
