[ 
https://issues.apache.org/jira/browse/KAFKA-12489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540939#comment-17540939
 ] 

Divij Vaidya commented on KAFKA-12489:
--------------------------------------

I have made some changes in [https://github.com/apache/kafka/pull/12197] which 
should help us understand whether the test is failing since file is directory 
or because it doesn't exist! Note that one of the problems is that we are not 
asserting the return value of File.createNewfiles() API, which could 
potentially be false. After this PR is merged in, we should see better 
exception messages to highlight the problem when this test fails.

> Flaky test 
> ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir
> ---------------------------------------------------------------------------------------
>
>                 Key: KAFKA-12489
>                 URL: https://issues.apache.org/jira/browse/KAFKA-12489
>             Project: Kafka
>          Issue Type: Bug
>          Components: system tests
>            Reporter: dengziming
>            Priority: Minor
>
> org.opentest4j.AssertionFailedError: expected: <true> but was: <false> at 
> org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) at 
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40) at 
> org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) at 
> org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:162) at 
> kafka.utils.TestUtils$.causeLogDirFailure(TestUtils.scala:1251) at 
> kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir(ControllerIntegrationTest.scala:329)
> details:
> [https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10289/2/testReport/junit/kafka.controller/ControllerIntegrationTest/Build___JDK_11___testPartitionReassignmentToBrokerWithOfflineLogDir__/]
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to